dblaikie added a comment. In D107155#2917400 <https://reviews.llvm.org/D107155#2917400>, @dexonsmith wrote:
> In D107155#2916664 <https://reviews.llvm.org/D107155#2916664>, @dblaikie > wrote: > >> Hmm, don't we have some other substitution feature that avoids the need to >> add the %? (like, I think LLVM's tests don't usually use the % for many tool >> names - but they still make for good copy/pastable command lines, if I'm not >> mistaken?) > > I think that'd be adding clang-scan-deps somehow to the `tools` variable in > clang/test/lit.cfg.py: > https://github.com/llvm/llvm-project/blob/main/clang/test/lit.cfg.py#L59 > (which will then call `add_tool_substitutions` at > https://github.com/llvm/llvm-project/blob/main/clang/test/lit.cfg.py#L111) Hmm, fair enough. Yeah - guess all the actual clang tests use %clang, %clang_cc1 - so I guess there's precedent in both directions. I wonder what the "norm" is (which tools use one approach, which use the other). But anyway, no objection in this case given the precedent. Though it does sound like this is a "tool" like the other cases, so maybe should be handled that way - up to you folks, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107155/new/ https://reviews.llvm.org/D107155 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
