amyk added inline comments.
================ Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1436 + +def int_ppc_ftdivdp : Intrinsic<[llvm_i32_ty], [llvm_double_ty, llvm_double_ty], [IntrNoMem]>; } ---------------- Line too long? ================ Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1724 + Intrinsic<[llvm_double_ty], [llvm_double_ty, llvm_double_ty], + [IntrNoMem]>; + def int_ppc_swdivs : GCCBuiltin<"__builtin_ppc_swdivs">, ---------------- Minor indentation nit. ================ Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1727 + Intrinsic<[llvm_float_ty], [llvm_float_ty, llvm_float_ty], + [IntrNoMem]>; } ---------------- Minor indentation nit. ================ Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:451 TargetPassConfig::addIRPasses(); + + addPass(createPPCLowerCheckedFPArithPass()); ---------------- Nit: Add a comment before creating the pass as the other pass calls also follow a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
