gandhi21299 marked an inline comment as done.
gandhi21299 added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12086
+ TargetLowering::AtomicExpansionKind Kind, bool UnsafeFlag) {
+ ORE = new OptimizationRemarkEmitter(RMW->getFunction());
+ if (Kind == TargetLowering::AtomicExpansionKind::CmpXChg) {
----------------
arsenm wrote:
> This is supposed to come from the pass, I don't think you can materialize
> this out of nowhere
I couldn't get `getAnalysis<OptimizationRemarkEmitterWrapperPass>().getORE()`
to work.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12100
+ }
+ delete ORE;
+ return Kind;
----------------
arsenm wrote:
> Should not need to create and delete, the analysis pass should own this
above comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://reviews.llvm.org/D106891
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
