leonardchan added a comment. In D99381#2911459 <https://reviews.llvm.org/D99381#2911459>, @vitalybuka wrote:
> In D99381#2911057 <https://reviews.llvm.org/D99381#2911057>, @eugenis wrote: > >> They are used here: >> https://cs.android.com/android/platform/superproject/+/master:bionic/libc/bionic/malloc_common.h;l=54;drc=f3968e89cb72400951f93a2a8237ac1428d2627c > > Thanks, it's preprocessor generated, so I can't find it :) > > If so I guess LGTM. > But now they are in the same file, so instead of declarations, maybe just > place SANITIZER_INTERFACE_ATTRIBUTE next to to the definition? Done. I'll take this as a review LGTM and submit tomorrow unless others have comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
