aaron.ballman added a comment.

In D103385#2900967 <https://reviews.llvm.org/D103385#2900967>, @jwtowner wrote:

> It should be good to go. I do not have commit access so feel free to commit. 
> Thanks!

Thanks! What name and email address would you like me to use for patch 
attribution?



================
Comment at: 
clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:34
+      template<typename... A,
+        enable_if_t<is_constructible_v<tuple<string,int>,A&&...>,int> = 0>
+      explicit Person(A&&... a) {}
----------------
jwtowner wrote:
> aaron.ballman wrote:
> > 
> The reason I didn't put the spaces in here was that I was trying to match the 
> style above for `enable_if_t<is_special<T>,void>`. I can add a space after 
> the comma there as well.
Ah, good call. The way it is now is good for me. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103385/new/

https://reviews.llvm.org/D103385

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to