jrtc27 added inline comments.
================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:233
+ // Use the explicitly target-feature to compute default ABI.
+ if (getABI().empty()) {
+ bool Is64Bit = getTriple().getArch() == llvm::Triple::riscv64;
----------------
I don't think using the getter makes sense. Currently it's entirely equivalent
to just reading ABI so serves little purpose, but in theory there could be
additional logic added to it (like asserting it's not empty) that would break
this. Given you already assume the name of the field below by assigning to it,
just read ABI directly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105555/new/
https://reviews.llvm.org/D105555
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
