erichkeane accepted this revision. erichkeane added a subscriber: rjmccall. erichkeane added a comment. This revision is now accepted and ready to land.
That test is fine, though the errors are quite jarring! I'm surprised how confused we get! This looks acceptable to me, but I'm not sufficiently an expert in this code to accept right away. Please give @rsmith (or perhaps @rjmccall ) at least 24 hrs after this to take a look before pushing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ https://reviews.llvm.org/D106583 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
