hubert.reinterpretcast added a comment.
LGTM with minor nit; thanks.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5140
+ A->render(Args, CmdArgs);
+ } else
D.Diag(diag::err_drv_invalid_argument_to_option)
----------------
Add braces to the `else` block when adding braces to the `if` block: The coding
guidelines have been updated for some time to discourage mixed bracing on
if/else chains (see example
```
// Use braces for the `if` block to keep it uniform with the else block.
```
).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106371/new/
https://reviews.llvm.org/D106371
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
