Anastasia added inline comments.
================
Comment at: clang/test/SemaOpenCL/null_literal.cl:26
#ifdef CL20
// Accept explicitly pointer to generic address space in OpenCL v2.0.
----------------
while we are at it, do you mind changing this check into
`__OPENCL_CPP_VERSION__ == 200`
and then we can remove `-DCL20` from the run line
================
Comment at: clang/test/SemaOpenCL/null_literal.cl:13
+#if defined(__OPENCL_CPP_VERSION__)
+// expected-error@+2{{cannot initialize a variable of type '__global int
*__private' with an rvalue of type '__global void *'}}
+#endif
----------------
Topotuna wrote:
> Anastasia wrote:
> > hmm, you should not get those errors though https://godbolt.org/z/qvr7x11TM
> The `expected-error` here refers to line 15 which displays an error:
> https://godbolt.org/z/zYzGedzv4
Makes sense. Sorry I didn't notice.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105987/new/
https://reviews.llvm.org/D105987
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
