dgoldman added a comment. > Well it is not as strong as that. We'll mostly rely on the fact that symbols > are nested properly. Since we just need to figure out the mark container for > a symbol, we don't care about the ordering (or am I missing something here?). > OTOH, range of the parent being accurate is indeed required. I think today it > is only broken for macro parents, but hopefully it shouldn't cause as any > troubles as in all the practical cases these are still contained inside an > AST node (I think), e.g:
I think the difficulty is when you "figure out the mark container for a symbol" since we implicitly scope the mark containers based on their location, it's possible the closest #pragma isn't the right container. I'm not sure of a simple way to do that without sorting, LMK if you have some ideas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
