pdhaliwal added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:252 + bool Wave64 = isWave64(DriverArgs, Kind); + + // TODO: There are way too many flags that change this. Do we need to check ---------------- JonChesterfield wrote: > I recognise this comment. Is this a bunch of logic that can be moved into the > base class and then called from here and hip? This is copied (after removing stuff related to opencl) from https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/AMDGPU.cpp#L841 I wanted to make call to `ROCMToolChain::addClangTargetOptions`, but there is some extra logic in it which is irrelevant to OpenMP. I will move the library linking into a separate common method as you suggest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105981/new/ https://reviews.llvm.org/D105981 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
