jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
typo in commit message.
Some minor suggestions. LG
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1211
auto Remark = [&](OptimizationRemark OR) {
- return OR << "Parallel region in "
- << ore::NV("OpenMPParallelDelete",
CI->getCaller()->getName())
- << " deleted";
+ return OR << "Removing unused parallel region.";
};
----------------
"unsused"? Maybe "side-effect free" or "empty"?
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2811
+
+ // Skip diagnostics on calls to known OpenMP runtime functinos for now.
+ if (auto *CB = dyn_cast<CallBase>(NonCompatibleI))
----------------
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2951
+ << "Call may contain unknown parallel regions. Use "
+ << "`__attribute__((assume(\"omp_no_openmp\")))` to
override.";
};
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105898/new/
https://reviews.llvm.org/D105898
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
