jdoerfert reopened this revision. jdoerfert added a comment. Herald added a subscriber: dexonsmith.
> A pthread_create() related test is XFAIL-ed, as it relied on it being > recognized as a builtin based on its name. > The builtin declaration syntax is too restrictive and doesn't allow custom > structs, function pointers, etc. > It seems to be the only case and fixing this would require reworking the > current builtin syntax, so this seems acceptable. First: Do I assume right this this feature was simply disabled without any plan to: - inform the authors (me) - update the documentation - re-enable support eventually or provide alternatives XFAILing a test and calling it a day seems inadequate IMHO. Second: Would an approach like this still work: https://reviews.llvm.org/D58531 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
