sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Great analysis, and the bailout seems reasonable. The overall algorithm seems
terribly confusing though :-(
================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:8340
}
+ // Bail out if we didn't make any correction progress on the checking
+ // TypoExpr TE, otherwise we risk running the loop forever.
----------------
Comment is good but maybe could mention the high-level effect of breaking out
(treat as unambiguous)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105533/new/
https://reviews.llvm.org/D105533
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
