bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.

lg


================
Comment at: include-fixer/SymbolIndexManager.cpp:45
@@ +44,3 @@
+      while (IdentiferContext != Names.rend() &&
+             SymbolContext != Symbol.getContexts().end()) {
+        if (SymbolContext->second == *IdentiferContext) {
----------------
It looks like we should rewrite this loop with early exits eventually. Not sure 
if that's a net win right now so I'm also fine with doing that when the code 
becomes more complex the next time.


Repository:
  rL LLVM

http://reviews.llvm.org/D20354



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to