vsavchenko accepted this revision.
vsavchenko added a comment.
This revision is now accepted and ready to land.
Great! Thanks for the detailed explanation in your Summary.
I agree that there should be a runtime check, but it doesn't seem viable as
long as `Checker.h` is organized the way it is organized now.
================
Comment at: clang/lib/StaticAnalyzer/Core/CheckerManager.cpp:40
+ int Unused[]{0, (Result |= !Callbacks.empty())...};
+ static_cast<void>(Unused);
+ return Result;
----------------
Maybe we can use `LLVM_ATTRIBUTE_UNUSED` instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105101/new/
https://reviews.llvm.org/D105101
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
