vsavchenko added a comment. In D103096#2822965 <https://reviews.llvm.org/D103096#2822965>, @ASDenysPetrov wrote:
> In D103096#2821750 <https://reviews.llvm.org/D103096#2821750>, @vsavchenko > wrote: > >> Hey, great work! I think that casts are extremely important, but it looks >> like you mixed so many things into this patch. Let's make one step at a >> time a split it into (at least) a couple of patches. > > Honestly, I don't know what part could be cut to keep this mechanism holistic > and self-sufficient. But I'll see what i can do. I know: solver part = separate patch. As I said, introduce a very minimal support in solver (aka `VisitSymbolCast` in `Inferrer`) and that's it. All other algorithms, like looking for constraints for the same expression, but casted to larger type, logically belong in a separate where you actually start producing symbolic casts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
