lebedev.ri added a comment.

In D104099#2813713 <https://reviews.llvm.org/D104099#2813713>, @aeubanks wrote:

> Some backends don't run SimplifyCFG, e.g. X86. I believe the pass was 
> originally created specifically for X86 (the header has some X86 examples) 
> and may or may not extend to other targets (I'm not very familiar with the 
> pass itself).
>
> I'm not opposed to landing this and seeing who complains, but if somebody 
> does, we can make this pass X86-specific by adding it to 
> X86TargetMachine::registerPassBuilderCallbacks() (which doesn't exist yet).

I am complaining about X86 side of things :)
It needs to be *at least* a late IR pass in codegen pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104099/new/

https://reviews.llvm.org/D104099

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to