Author: Keith Smiley Date: 2021-06-09T09:04:37-07:00 New Revision: 1c7f3395b8ec52462220898495883ec570390367
URL: https://github.com/llvm/llvm-project/commit/1c7f3395b8ec52462220898495883ec570390367 DIFF: https://github.com/llvm/llvm-project/commit/1c7f3395b8ec52462220898495883ec570390367.diff LOG: clang/darwin: use response files with ld64 This crasher was fixed with Xcode 13.0 beta 1 / ld64 705. This is an updated revert of https://reviews.llvm.org/D92357 Differential Revision: https://reviews.llvm.org/D103934 Added: Modified: clang/lib/Driver/ToolChains/Darwin.cpp Removed: ################################################################################ diff --git a/clang/lib/Driver/ToolChains/Darwin.cpp b/clang/lib/Driver/ToolChains/Darwin.cpp index 5ccd2300afd39..8a0c4721eea0e 100644 --- a/clang/lib/Driver/ToolChains/Darwin.cpp +++ b/clang/lib/Driver/ToolChains/Darwin.cpp @@ -711,10 +711,7 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA, } ResponseFileSupport ResponseSupport; - if (LinkerIsLLDDarwinNew) { - // Xcode12's ld64 added support for @response files, but it's crashy: - // https://openradar.appspot.com/radar?id=4933317065441280 - // FIXME: Pass this for ld64 once it no longer crashes. + if (Version[0] >= 705 || LinkerIsLLDDarwinNew) { ResponseSupport = ResponseFileSupport::AtFileUTF8(); } else { // For older versions of the linker, use the legacy filelist method instead. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
