MaskRay added a comment. How do the new tests provide additional coverage?
================ Comment at: clang/test/Driver/riscv-arch.c:45 + +// CHECK-ILP32: "-target-feature" "+m" +// CHECK-ILP32-SAME: "-target-feature" "+f" ---------------- I suggest the style used in linux-cross.cpp Just using `-SAME` cannot detect unrelated strings between "-target-feature" "+m" and "-target-feature" "+f" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103878/new/ https://reviews.llvm.org/D103878 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
