DmitryPolukhin created this revision.
DmitryPolukhin added reviewers: teemperor, obruns, bruno.
DmitryPolukhin requested review of this revision.
Herald added a project: clang.
This diff adds testcase for the issue fixed in https://reviews.llvm.org/D77468
but regression test was not added in the diff. On Clang 9 it caused
crash in cland during code completion.
Test Plan: check-clang-unit
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D103722
Files:
clang/unittests/AST/CommentTextTest.cpp
Index: clang/unittests/AST/CommentTextTest.cpp
===================================================================
--- clang/unittests/AST/CommentTextTest.cpp
+++ clang/unittests/AST/CommentTextTest.cpp
@@ -124,4 +124,11 @@
// clang-format on
}
+TEST_F(CommentTextTest, EmptyFormattedText) {
+ // Test that empty formatted text doesn't cause crash.
+ auto ExpectedOutput = "";
+ auto Formatted = formatComment("//!<");
+ EXPECT_EQ(ExpectedOutput, Formatted);
+}
+
} // namespace clang
Index: clang/unittests/AST/CommentTextTest.cpp
===================================================================
--- clang/unittests/AST/CommentTextTest.cpp
+++ clang/unittests/AST/CommentTextTest.cpp
@@ -124,4 +124,11 @@
// clang-format on
}
+TEST_F(CommentTextTest, EmptyFormattedText) {
+ // Test that empty formatted text doesn't cause crash.
+ auto ExpectedOutput = "";
+ auto Formatted = formatComment("//!<");
+ EXPECT_EQ(ExpectedOutput, Formatted);
+}
+
} // namespace clang
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
