MaskRay added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:935
+ // data variables can be private. This optimization applies on COFF and ELF.
+ if (!DataReferencedByCode && !TT.isOSBinFormatMachO()) {
+ Linkage = GlobalValue::PrivateLinkage;
----------------
I am conservative here. For ELF `__profd_*` can be unconditionally private,
even in `DataReferencedByCode == true` mode. This will decrease object file
sizes for regular PGO.
But there may be too many changes now. I'll postpone doing this after this
proves to be stable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103372/new/
https://reviews.llvm.org/D103372
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
