phosek added inline comments.
================
Comment at: compiler-rt/lib/hwasan/CMakeLists.txt:45
+if (NOT FUCHSIA)
+ append_list_if(COMPILER_RT_HWASAN_WITH_INTERCEPTORS
HWASAN_WITH_INTERCEPTORS=1 HWASAN_DEFINITIONS)
+else()
----------------
mcgrathr wrote:
> It might be better to force the value of COMPILER_RT_HWASAN_WITH_INTERCEPTORS
> to OFF instead.
>
> But I'll leave the cmake details to Petr.
>
That would be my preference. The patter we usually use is:
```
if(FUCHSIA)
set(COMPILER_RT_HWASAN_WITH_INTERCEPTORS_DEFAULT OFF)
else()
set(COMPILER_RT_HWASAN_WITH_INTERCEPTORS_DEFAULT ON)
endif()
set(COMPILER_RT_HWASAN_WITH_INTERCEPTORS
${COMPILER_RT_HWASAN_WITH_INTERCEPTORS_DEFAULT} CACHE BOOL "Enable libc
interceptors in HWASan (testing mode)")
```
which would be set in
https://github.com/llvm/llvm-project/blob/07c2a912ddf1641b969fdbae3418f77c362f67c6/compiler-rt/CMakeLists.txt#L70.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103544/new/
https://reviews.llvm.org/D103544
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
