sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits.
Sorry about delay. ================ Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:555 + case Config::ExternalIndexSpec::None: + break; case Config::ExternalIndexSpec::Server: ---------------- I think you hit llvm_unreachable here - is this an invariant enforced by the caller, or did you mean to return nullptr? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100308/new/ https://reviews.llvm.org/D100308 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
