yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: clang/test/SemaCUDA/asm_delayed_diags.cu:31
static __device__ __host__ double t3(double x) {
- register long double result;
+ register long double result; // expected-warning {{'register' storage class
specifier is deprecated and incompatible with C++17}}
__asm __volatile("frndint"
----------------
tra wrote:
> Perhaps we should just remove the `register`.
> TBH, I'm not quite sure what this test is supposed to do for NVPTX -- `t` is
> not a register class in NVPTX nor does it seem to be a generic constraint.
>
> I guess the idea was that we should ignore asm errors in the host code, while
> we're compiling for device. In that case, we certainly do not need `register`
removed register.
I think this test is for deferred diags.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103221/new/
https://reviews.llvm.org/D103221
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
