MyDeveloperDay added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:14921
+ verifyFormat("unsigned int *a;\n"
+ "int *b;\n"
"unsigned int Const *c;\n"
----------------
I seem to remember in the past there was a comment from @djasper in the past
that he felt you shouldn't align the * like this
I think it depends on your viewpoint as to whether the * goes with the type or
the variable, this could be a religious debate, I don't think you can just
assume everyone agrees with this, the fact you are changing unit tests just
leaves me with alarm bells going off...
I'm not comfortable with you changing unit tests. This implies that you think
its a bug, but I think the fact the test exists (Beyonce rule), means someone
may have wanted to assert that behaviour.
Should we have an option to control this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103245/new/
https://reviews.llvm.org/D103245
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
