erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:7127
<< FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
+ } else if (SC == SC_Static && DC->isFileContext() &&
+ getLangOpts().CPlusPlus17) {
----------------
First, what about this is C++17 specific? The inline and static relationship
is older than C++17, right?
Also, are you sure that the warning/stuff in the 'else' isn't still valuable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102663/new/
https://reviews.llvm.org/D102663
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
