kadircet added a comment.
thanks, lgtm!
================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:215
nullptr);
- for (const auto &T :
- prepareTweaks(Selection, Opts.TweakFilter, Opts.FeatureModules)) {
+ auto Tweaks =
+ prepareTweaks(Selection, Opts.TweakFilter, Opts.FeatureModules);
----------------
IIUC, the ordering here is to ensure `FS` is not available during `prepare` but
exists in `apply`. That sounds sane, as we would like prepare to be fast, and
IO is likely slow.
But this is very subtle, so deserves a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102519/new/
https://reviews.llvm.org/D102519
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
