bruno added a comment.

Overall looks good, one more comment below.



================
Comment at: clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp:20
 class C {
+public:
   int g();
----------------
bruno wrote:
> > The change to clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp 
> > is to silence an uninteresting access error that the above change causes.
> 
> The fact that the access check changed for previous version of the language 
> (not necessarily related to p1099) indicates that this specific change 
> deserves its own patch.
How about this one?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100276/new/

https://reviews.llvm.org/D100276

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to