JonChesterfield added inline comments.
================ Comment at: openmp/libomptarget/deviceRTLs/common/src/omptarget.cu:195 + +EXTERN __attribute__((weak)) +int32_t __kmpc_target_init(ident_t *Ident, bool IsSPMD, ---------------- jdoerfert wrote: > JonChesterfield wrote: > > why are these weak? > So we do not perform IPO but will inline them. If we perform IPO we > specialize the arguments even though we still want to do potentially change > the mode from non-SPMD to SPMD. as discussed offline, weak_odr or drop the weak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://reviews.llvm.org/D101976 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
