dmgreen added a comment. I don't know a huge amount about stack protectors.
It's worth adding -verify-machineinstrs to the tests, to check the code passes the internal checks. ================ Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1917 + .addDef(Reg) + .addImm(Options.StackProtectorGuardOffset >> 3); + else ---------------- What is StackProtectorGuardOffset, and could is be out of range for the load? That is something that verify-machineinstrs won't currently check for. ================ Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1920 + BuildMI(MBB, MI, DL, get(AArch64::LDURXi)) + .addUse(Reg, RegState::Kill) + .addDef(Reg) ---------------- Defs come before Uses in machine instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
