jansvoboda11 added a comment.
@dexonsmith ping
================
Comment at: clang/lib/Serialization/ASTReader.cpp:5621
+ // FIXME: NameAsWritten
+ ModMap.setUmbrellaHeader(CurrentModule, *Umbrella, Blob, "");
else if (CurrentModule->getUmbrellaHeader().Entry != *Umbrella) {
----------------
jansvoboda11 wrote:
> Not sure what's the best way to write/read the two strings (`NameAsWritten`,
> `PathRelativeToRootModuleDirectory`). Can we put them into a single blob and
> separate them with `\0`?
I think we can store them in whatever format we want and separating them by
`'\0'` should be fine.
However, I'm not convinced we need to do so in this patch. Deserialized
`NameAsWritten` isn't being used anyway, meaning we have no interesting test
case for serialization that would ensure it works as expected.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100934/new/
https://reviews.llvm.org/D100934
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
