fhahn added a comment. Thanks for the update! Technically the fix in `clang/lib/CodeGen/CGExprScalar.cpp` is unrelated to C++ support. It would be great if you could put up a separate patch, so we can land this independently.
The whole patch basically LGTM. It would be great if you could add a test casting from unsigned to float/double (looks like no test generates `uitofp`) and a test for casting between signed & unsigned integers of the same size (unless there are already tests for that I missed) ================ Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1209 - // Allow bitcast between matrixes of the same size. - if (SrcTy->getPrimitiveSizeInBits() == DstTy->getPrimitiveSizeInBits()) - return Builder.CreateBitCast(Src, DstTy, "conv"); ---------------- Could you s ================ Comment at: clang/test/CodeGenCXX/matrix-casts.cpp:4 +template <typename X> + +using matrix_4_4 = X __attribute__((matrix_type(4, 4))); ---------------- nit: drop the newline here and before `using matrix_5_5...` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101696/new/ https://reviews.llvm.org/D101696 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
