nickdesaulniers added a comment. The additions of `-Wno-unused-but-set-variable` to:
- clang/test/SemaObjC/foreach.m - clang/test/SemaCXX/sizeless-1.cpp - clang/test/SemaCXX/shift.cpp - clang/test/SemaCXX/goto.cpp - clang/test/Sema/vector-gcc-compat.cpp - clang/test/Sema/vector-gcc-compat.c - clang/test/FixIt/fixit.cpp - clang/test/CodeGen/builtins-arm.c - clang/test/CodeGen/builtins-riscv.c - clang/test/CXX/expr/expr.prim/expr.prim.lambda/p12.cpp ... all the one line changes to tests that add this warning flag to the run line look questionable to me; we generally don't add new warning flags to a ton of existing tests. Were those cases that were previously failing? Were those accidentally committed? I would have expected this change to be: - changes to enable the flag and do something - block of additional test cases - changes to existing tests if they were failing this new check inadvertantly. But adding a new warning flags to a handful of existing tests' RUN lines is unusual. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
