yaxunl marked an inline comment as done. yaxunl added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:131-133 + "invalid argument '-mno-amdgpu-ieee' only allowed with floating point options " + "which do not honor NaNs, e.g. '-fno-honor-nans', '-ffast-math', " + "'-ffinite-math-only', etc.">; ---------------- arsenm wrote: > e.g. and a list of flags seems weird for an error message. How about "only > allowed with relaxed NaN handling"? sounds good. will do. I think users should be able to look up clang options which relax NaN handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77013/new/ https://reviews.llvm.org/D77013 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
