delcypher added inline comments.
================ Comment at: clang/include/clang/Basic/CodeGenOptions.def:225-228 +ENUM_CODEGENOPT(SanitizeAddressDetectStackUseAfterReturnMode, + llvm::AsanDetectStackUseAfterReturnMode, 2, + llvm::AsanDetectStackUseAfterReturnMode::Runtime + ) ///< Set detection mode for stack-use-after-return. ---------------- vitalybuka wrote: > vitalybuka wrote: > > Mode->Kind to be consistent with the file > I believe for consistency we need: > 1. Var name (SanitizeAddressDetectStackUseAfterReturn) no Mode/Kind suffix > 2. Enum type AsanDetectStackUseAfterReturnKind uses "kind" > 3. Actual flag includes no "kind" > -fsanitize-address-detect-stack-use-after-return= > > BTW. @delcypher -fsanitize-address-destructor-kind was not consistent with > the rest of file, but I am not sure it's worth of fixing now. > > @vitalybuka It's not too late to fix this because the `-fsanitize-address-destructor-kind=` flag hasn't been adopted yet AFAIK. Am I right in understanding that what I landed doesn't match points 1 and 3 above? If you can confirm that's what you'd like to be changed I can put up some patches to fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101122/new/ https://reviews.llvm.org/D101122 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
