compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
This is a pretty straightforward cleanup now, which adds additional
functionality by deferring work to CMake. There are a couple of minor points
about inconsistent quoting but this seems good otherwise.
================
Comment at: clang-tools-extra/clang-doc/tool/CMakeLists.txt:26
install(FILES ../assets/index.js
- DESTINATION share/clang
+ DESTINATION "${CMAKE_INSTALL_DATADIR}/clang"
COMPONENT clang-doc)
----------------
Why are these quoted but other uses not?
================
Comment at: flang/CMakeLists.txt:442
install(DIRECTORY include/flang
- DESTINATION include
+ DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
COMPONENT flang-headers
----------------
Why is this quoted but other uses not?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99484/new/
https://reviews.llvm.org/D99484
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
