nickdesaulniers marked an inline comment as not done. nickdesaulniers added inline comments.
================ Comment at: clang/test/Driver/stack-protector-guard.c:59 +// INVALID-VALUE-AARCH64: error: invalid value 'tls' in 'mstack-protector-guard=','valid arguments to '-mstack-protector-guard=' are:sysreg global' +// INVALID-REG-AARCH64: error: invalid value 'foo' in 'mstack-protector-guard-reg=','for AArch64' ---------------- nickdesaulniers wrote: > DavidSpickett wrote: > > I'm not sure if this is due to your code or the error machinery itself but > > these errors are strangely written. > > > > I'd expect: > > ``` > > error: invalid value 'tls' in 'mstack-protector-guard='tls', valid > > arguments to '-mstack-protector-guard=' are:sysreg global' > > ``` > > > > Maybe it's assuming that there could be multiple values and `','` means > > that list option treats the value as a list? Or it's not using the right > > value and the comma is meant to be after the `=''` as in my example. > Sure, `err_drv_invalid_value` would be better. Ah, `err_drv_invalid_value_with_suggestion` puts single quotes around the third parameter `%2`. Let me send a patch cleaning that up, then I'll rebase this on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
