spatel added inline comments.
================
Comment at:
llvm/test/Transforms/PhaseOrdering/unsigned-multiply-overflow-check.ll:20
+; FIXME: noundef should be attached to args
define i1 @will_not_overflow(i64 %arg, i64 %arg1) {
----------------
Any ideas about what it will take to get those argument attributes for the C++
source example shown in the code comment?
SDAG is still going to convert the `select` to `and`, so we can probably avoid
regressions by replicating InstSimplify's
omitCheckForZeroBeforeMulWithOverflow() as a DAG combine. Let me know if I
should do that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101191/new/
https://reviews.llvm.org/D101191
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
