aaron.ballman added a comment. In D101192#2716596 <https://reviews.llvm.org/D101192#2716596>, @mibintc wrote:
> Wow thanks for doing this! I worked on it a couple days a while ago but I > abandoned the effort and went back to my day job. Happy to help! > It seems like preprocessing ought to be something like a "state machine" but > I couldn't figure out the mechanism. Would it make sense to add some kind of > high level description of the components, now that you've gone to the > [presumably massive] effort of understanding it? Just a couple small comments > above. Adding some developer documentation about the preprocessor may not be a bad idea in general, but I think that's orthogonal to this patch. We do have a place to add those kind of docs and it looks like the preprocessor is largely not mentioned: https://clang.llvm.org/docs/InternalsManual.html#the-lexer-and-preprocessor-library. However, I'd prefer not to sign up to write those docs at this time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
