azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land.
Generally looks good to me, but maybe a test needed, see a comment. Thanks! But I'm still not sure about completely removing pragmas for type declarations (see https://reviews.llvm.org/D100980#2719196). ================ Comment at: clang/include/clang/Basic/OpenCLImageTypes.def:68 IMAGE_WRITE_TYPE(image2d_array_msaa_depth, OCLImage2dArrayMSAADepth, "cl_khr_gl_msaa_sharing") -IMAGE_WRITE_TYPE(image3d, OCLImage3d, "cl_khr_3d_image_writes") +IMAGE_WRITE_TYPE(image3d, OCLImage3d, "") ---------------- Maybe we should add a test to check that` image3d_t` is reserved? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100983/new/ https://reviews.llvm.org/D100983 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
