ychen added a comment.

In D100739#2717227 <https://reviews.llvm.org/D100739#2717227>, @rjmccall wrote:

> Yes, if you can dynamically choose to use an aligned allocator, that's 
> clearly just much better.

Right now:

Intrinsic::coro_size_aligned :   overaligned frame: over-allocate, adjust start 
address;    non-overaligned frame: no-op
Intrinsic::coro_size :                overaligned frame: no-op;                 
                                non-overaligned frame: no-op

Do you mean to remove `Intrinsic::coro_size_aligned` and make 
Intrinsic::coro_size :                overaligned frame: over-allocate, adjust 
start address;    non-overaligned frame: no-op

that makes sense to me. Just want to confirm first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100739/new/

https://reviews.llvm.org/D100739

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to