nickdesaulniers added inline comments. Herald added a subscriber: tmatheson.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3104 << A->getAsString(Args) << TripleStr; - if (Value != "tls" && Value != "global") { + if (Value != "tls" && Value != "global" && Value != "sysreg") { D.Diag(diag::err_drv_invalid_value_with_suggestion) ---------------- TODO: tls is not supported on aarch64 in GCC. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3114 if (Arg *A = Args.getLastArg(options::OPT_mstack_protector_guard_offset_EQ)) { StringRef Value = A->getValue(); ---------------- TODO: GCC treats this as mutually exclusive when OPT_mstack_protector_guard_EQ == global. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits