jdoerfert added a comment. In D91054#2708924 <https://reviews.llvm.org/D91054#2708924>, @AMDChirag wrote:
> In D91054#2708873 <https://reviews.llvm.org/D91054#2708873>, @jdoerfert wrote: > >> What is missing or not working in the IRBuilder impl that prevents us from >> turning it on by default? > > Per the `TODO` in this patch (`CGStmtOpenMP.cpp - 3775`), > `PrivatizationCallback` is not working right now. > I can't think of anything else. The test cases are all working so there's > that. OK, we really need to provide the PrivCB impl so we can start removing clang code. This is generally fine with me, @fghanim @Meinersbur any concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
