davezarzycki added a comment. In D99949#2709497 <https://reviews.llvm.org/D99949#2709497>, @JonChesterfield wrote:
> In D99949#2709297 <https://reviews.llvm.org/D99949#2709297>, @davezarzycki > wrote: > >> This change broke multi-stage builds (even if AMDGPU is disabled as a >> target). The problem is that clang/tools/amdgpu-arch/AMDGPUArch.cpp can't >> find hsa.h. Is there a quick fix? > > That should not be the case. The cmake for building AMDGPUArch.cpp is guarded > by > > find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS > /opt/rocm) > if (NOT ${hsa-runtime64_FOUND}) > return > > The intent is for this to be built only when hsa-runtime64 is found on disk, > at which point hsa.h is meant to be found within that package via cmake > magic. Perhaps we need to explicitly specify the include directory, though we > do not do so in the openmp plugin this was copied from, and I do not have > hsa.h on any global search path. > > Little harm will be done by reverting this (again...) and reapplying, but it > would be really helpful if you can share some more information about the > build config that is failing. As it turns out, I do have the HSA runtime installed so perhaps the problem is that the header is actually hsa/hsa.h and not hsa.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
