fhahn added a reviewer: mibintc. fhahn added a subscriber: mibintc. fhahn added a comment.
Awesome, thanks for the patch! I'm also adding @mibintc who I think was working on adding support for the pragma & co. Could you add a brief description to the patch and also reference the bug report on bugs.llvm.org? ================ Comment at: clang/test/CodeGen/fp-matrix-pragma.c:1 +// RUN: %clang_cc1 -emit-llvm -S -fenable-matrix --target=arm64-unknown-iphoneos -g0 -mllvm -disable-llvm-optzns -o - | FileCheck %s + ---------------- I don't think we need `--target=arm64-unknown-iphoneos` or `-g0`? ================ Comment at: clang/test/CodeGen/fp-matrix-pragma.c:23 +// CHECK: call <4 x i32> @llvm.matrix.multiply.v4i32.v4i32.v4i32 +// CHECK: add <4 x i32> +#pragma clang fp contract(fast) reassociate(on) ---------------- could you also add a float test that has both `contract(fast) reassociate(on)`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
