probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

One optional nit and LGTM, assuming the DILocalVariable ordering is consistent 
with what we see downstream.



================
Comment at: clang/test/CodeGenCoroutines/coro-dwarf.cpp:1
-// RUN: %clang_cc1 -std=c++2a -fcoroutines-ts -triple=x86_64 -dwarf-version=4 
-debug-info-kind=limited -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -disable-llvm-optzns -std=c++2a -fcoroutines-ts \
+// RUN:            -triple=x86_64 -dwarf-version=4 -debug-info-kind=limited \
----------------
I prefer the spelling `-disable-llvm-passes` 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100298/new/

https://reviews.llvm.org/D100298

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to