njames93 added inline comments.
================ Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:1294 + +#ifndef _WIN32 +TEST(Introspection, SourceLocations_TypeOfTypeLoc) { ---------------- steveire wrote: > njames93 wrote: > > Can you add a comment explaining the issues with this test on windows > > platforms. > I don't know what the problem is, but it failed: > https://reviews.llvm.org/B98791 I'm guessing on windows the typeof extension is disabled, I'd guess you could try buildASTFromCodeWithArgs and pass `-std=gnu++11`. However in all honesty I'd be happy if you just added a comment to say this test doesn't work on windows due to use of the typeof extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100516/new/ https://reviews.llvm.org/D100516 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits