rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: clang/lib/CodeGen/TargetInfo.cpp:6106 uint64_t Members = 0; IsIndirect = !isHomogeneousAggregate(Ty, Base, Members); } ---------------- rnk wrote: > Do we need to worry about H[VF]As passed to variadic functions, or is there a > special case when passing those to variadics? After looking at D100365, I'm assuming the answer is yes. It would be surprising if an HFA passed to a variadic function is passed in integer registers. I suppose it could be passed directly in memory instead of indirectly, but that also seems unlikely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100374/new/ https://reviews.llvm.org/D100374 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits