lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed.
In D98070#2616042 <https://reviews.llvm.org/D98070#2616042>, @lebedev.ri wrote: > Please also add a test with global `IgnoreMacros=1` and > `readability-function-cognitive-complexity.IgnoreMacros` unset. > (The code is correct as-is, global `IgnoreMacros` should not affect the check > here.) > > I'm also somewhat worried about forward compatibility. > If in future a mode will be implemented that allows to count the cost of > macro arguments, > how'd we expose it in check's params, without breaking the existing > `IgnoreMacros=1` config support? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/ https://reviews.llvm.org/D98070 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
